crypto: deprecate _toBuf #22501
Closed
crypto: deprecate _toBuf #22501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
crypto
tniessen
added
the
semver-major
lpinca
reviewed
Aug 24, 2018
doc/api/deprecations.md
Outdated
| Type: Runtime | ||
|
|
||
| The `crypto._toBuf()` function was not designed to be used by modules outside | ||
| of Node.js core and will become unavailable in the future. |
There was a problem hiding this comment.
Maybe change "will become unavailable" with "will be removed"?
lpinca
approved these changes
Aug 24, 2018
trivikr
approved these changes
Aug 24, 2018
jasnell
approved these changes
Aug 24, 2018
trivikr
approved these changes
Aug 24, 2018
trivikr
added
the
author ready
BridgeAR
approved these changes
Aug 24, 2018
benjamingr
approved these changes
Aug 24, 2018
addaleax
approved these changes
Aug 24, 2018
|
@nodejs/security-wg |
lundibundi
approved these changes
Aug 25, 2018
|
Seems like CI was interrupted, resumed in: https://ci.nodejs.org/job/node-test-pull-request/16761/ |
tniessen
added a commit
that referenced
this pull request
Aug 27, 2018
PR-URL: #22501 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
tniessen
added a commit
that referenced
this pull request
Aug 27, 2018
PR-URL: #22501 Fixes: #22425 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Aug 27, 2018
2 tasks
tniessen
removed
the
author ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is almost trivial and was not supposed to be visible outside of Node.js core.
I am not entirely happy with the wording in the deprecation documentation, suggestions are welcome.
Fixes: #22425
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes